Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when drag/modifying tag range while transform state is active. #4375

Open
Gasparoken opened this issue Mar 18, 2024 · 2 comments · May be fixed by #4418
Open

Crash when drag/modifying tag range while transform state is active. #4375

Gasparoken opened this issue Mar 18, 2024 · 2 comments · May be fixed by #4418
Assignees
@Gasparoken
Labels
crash report Issue originated from a crash report / .dmp file low priority timeline
Milestone
v1.3.7

Comments

@Gasparoken
Copy link
Member

Internal report: https://igarastudio.zendesk.com/agent/tickets/5932

Aseprite and System version

  • Aseprite version: 1.3.5
  • System: Windows/macOS
@Gasparoken Gasparoken added critical priority timeline time-2 crash report Issue originated from a crash report / .dmp file labels Mar 18, 2024
@Gasparoken Gasparoken added this to the v1.3.6 milestone Mar 18, 2024
@Gasparoken Gasparoken self-assigned this Mar 18, 2024
@Gasparoken
Copy link
Member Author

The crash was solved via 7905acf (related to #4367).

Anyway, it may be good to define the default behavior:

  1. Cancel the transformation
  2. Just drop the pixels
  3. Lock this kind of actions (just 7905acf)
  4. Allow the action (can be done via: "drop the pixels" and re-catch after the tag limit modification).
  5. Other?

What do you think @dacap?

@Gasparoken Gasparoken removed their assignment Mar 18, 2024
@dacap
Copy link
Member

dacap commented Mar 20, 2024

Now that the crash is fixed, instead of showing the error message, we could just drop the pixels (without re-catch, just dropping the pixels, if the user moves the pixels the transformation starts again).

@Gasparoken Gasparoken self-assigned this Mar 20, 2024
@dacap dacap modified the milestones: v1.3.6, v1.3.7 Apr 9, 2024
Gasparoken added a commit to Gasparoken/aseprite that referenced this issue Apr 16, 2024
@Gasparoken
Fix drop pixels when drag/modifying tag range while transform state i…
5a5d6d3 
…s active (fiix aseprite#4375)

Before this fix, aseprite displayed an error message instead of dropping pixels.
@Gasparoken Gasparoken linked a pull request Apr 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gasparoken Gasparoken

Labels
crash report Issue originated from a crash report / .dmp file low priority timeline
Projects
Aseprite v1.3.x
Status: Done
Milestone
v1.3.7
2 participants
@dacap @Gasparoken