Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not clone aseprite/strings.git during the build #4489

Open
vigress8 opened this issue May 22, 2024 · 2 comments
Open

Add option to not clone aseprite/strings.git during the build #4489

vigress8 opened this issue May 22, 2024 · 2 comments

Comments

@vigress8
Copy link

vigress8 commented May 22, 2024

If Aseprite finds git during the build, it tries to clone the strings repo, which is undesirable if it's e.g. already cloned manually. I maintain a build script which runs in an environment without an internet connection by default, so I had to patch out this behaviour:
https://github.com/pacstall/pacstall-programs/blob/30d70ece43b0bca6048bd774b517e25e5e849a6a/packages/aseprite/dont-clone-strings.patch

Adding a cmake flag for this would be useful

@dacap
Copy link
Member

dacap commented Jun 7, 2024

Hi @vigress8, could you test if using FETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON option does fix your issue?

@vigress8
Copy link
Author

vigress8 commented Jun 8, 2024

Hi @vigress8, could you test if using FETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON option does fix your issue?

Yep, it does. Thanks, not very knowledgeable on CMake. You're free to close this if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants