Skip to content

Commit

Permalink
Use separate SKSHAPER_DLL define to activate shared library logic
Browse files Browse the repository at this point in the history
Change-Id: I35cd463fd85920651a940a9af131f7b6515c2a3a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/267676
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
  • Loading branch information
brianosman authored and Skia Commit-Bot committed Jan 30, 2020
1 parent a5ec04d commit 3e98c0e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions modules/skshaper/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ if (skia_enable_skshaper) {
config("public_config") {
include_dirs = [ "include" ]
defines = []
if (is_component_build) {
defines += [ "SKSHAPER_DLL" ]
}
if (skia_use_icu) {
defines += [ "SK_SHAPER_HARFBUZZ_AVAILABLE" ]
}
Expand Down
2 changes: 1 addition & 1 deletion modules/skshaper/include/SkShaper.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#endif

#if !defined(SKSHAPER_API)
#if defined(SKIA_DLL)
#if defined(SKSHAPER_DLL)
#if defined(_MSC_VER)
#if SKSHAPER_IMPLEMENTATION
#define SKSHAPER_API __declspec(dllexport)
Expand Down

0 comments on commit 3e98c0e

Please sign in to comment.