Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Adding WithURL connection options #20

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Adding WithURL connection options #20

merged 1 commit into from
Jan 12, 2022

Conversation

ronenh
Copy link
Collaborator

@ronenh ronenh commented Jan 12, 2022

This allows grpc callers to use Unix sockets in addition normal DNS URLs.

WithURL and WithAddr are mutually exclusive.

When connecting to the Aserto authorizer over gRPC, URLs must satisfy the gRPC naming requirements.

This allows grpc callers to use Unix sockets in addition normal DNS URLs.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1685656257

  • 50 of 73 (68.49%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 58.131%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/options.go 39 49 79.59%
authorizer/http/authorizer.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
authorizer/http/authorizer.go 1 0%
Totals Coverage Status
Change from base Build 1684713058: 0.5%
Covered Lines: 479
Relevant Lines: 824

💛 - Coveralls

@gertd gertd merged commit df2a679 into main Jan 12, 2022
@gertd gertd deleted the 180879739/with-url branch January 12, 2022 06:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants