Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup generics usage #87

Merged
merged 5 commits into from
Apr 1, 2024
Merged

cleanup generics usage #87

merged 5 commits into from
Apr 1, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Mar 27, 2024 •
edited
Loading

  • use samber/lo generic func when exists instead of private implementations
  • update gh actions to node-20 supported versions
  • update compiler version to golang 1.22
  • update go dependencies

@gertd gertd marked this pull request as draft March 27, 2024 14:39
@gertd gertd changed the title use samber/lo instead of private impl cleanup generics usage Mar 27, 2024
@coveralls
Copy link

coveralls commented Mar 27, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 8484872371

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 31.063%
Totals Coverage Status
Change from base Build 8439610840: -0.09%
Covered Lines: 1131
Relevant Lines: 3641
💛 - Coveralls

@gertd gertd marked this pull request as ready for review March 29, 2024 19:50
@gertd gertd requested a review from ronenh March 29, 2024 19:52
@gertd gertd merged commit de6a55f into main Apr 1, 2024
2 checks passed
@gertd gertd deleted the chore/cleanup-generics branch April 1, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh Awaiting requested review from ronenh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gertd @coveralls