Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm v2 directory interfaces #92

Merged
merged 4 commits into from
Jun 11, 2024
Merged

rm v2 directory interfaces #92

merged 4 commits into from
Jun 11, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Jun 3, 2024

Remove v2 directory support from go-edge-ds, v2 was already disabled per topaz v0.32.0, this PR removes the code.

@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9467371676

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 139 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-2.0%) to 25.468%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/directory/v3/reader.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/directory/directory.go 1 70.23%
pkg/bdb/migrate/mig/mig.go 2 27.37%
pkg/bdb/boltdb.go 5 53.85%
pkg/bdb/metadata.go 5 69.57%
pkg/ds/object.go 6 53.85%
pkg/bdb/scanner.go 8 34.31%
pkg/bdb/generic.go 8 38.1%
pkg/ds/relation.go 15 56.05%
pkg/directory/v3/writer.go 40 30.11%
pkg/directory/v3/reader.go 49 13.55%
Totals Coverage Status
Change from base Build 9277923225: -2.0%
Covered Lines: 857
Relevant Lines: 3365

💛 - Coveralls

@gertd gertd marked this pull request as ready for review June 6, 2024 08:20
Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep the commented out tests ?

@gertd
Copy link
Member Author

gertd commented Jun 11, 2024

@carabasdaniel Thanks for the review, the commented out test I will remove, these should indeed not be there

@gertd gertd merged commit 3404cb0 into main Jun 11, 2024
2 checks passed
@gertd gertd deleted the rm-directory-v2 branch June 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants