Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the "manager" relation in citadel and acmecorp #328

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Feb 28, 2024

In order to use the manager relation in ReBAC scenarios, where users up the management chain can operate on their reports or gain access to resources that they have, the direction of the relation should be from the employee (object) to the manager (subject).
This PR flips the direction.

Copy link

github-actions bot commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8802125421

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 996 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-11.4%) to 23.954%

Files with Coverage Reduction New Missed Lines %
pkg/cli/cc/dir.go 2 50.0%
pkg/app/topaz/wire_gen.go 2 51.85%
directory/identity.go 2 60.87%
pkg/testing/logger.go 3 68.57%
pkg/testing/assets.go 3 68.75%
pkg/app/impl/jwt.go 4 14.44%
pkg/app/middlewares/tenant.go 6 72.73%
pkg/cli/cc/cc.go 9 0.0%
builtins/edge/ds/user.go 10 65.63%
builtins/edge/ds/identity.go 10 57.14%
Totals Coverage Status
Change from base Build 8077633159: -11.4%
Covered Lines: 1145
Relevant Lines: 4780

💛 - Coveralls

BogdanIrimie
BogdanIrimie previously approved these changes Feb 29, 2024
gertd
gertd previously approved these changes Feb 29, 2024
@ronenh ronenh dismissed stale reviews from gertd and BogdanIrimie via 56e4e71 April 23, 2024 14:22
gertd
gertd previously approved these changes Apr 23, 2024
@ronenh ronenh merged commit 8b2c337 into main Apr 23, 2024
5 checks passed
@ronenh ronenh deleted the manager-relation branch April 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants