feat(react): add providers & custom hooks #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generates a theme that can be passed to the ThemeProvider
dasuni-30
reviewed
May 15, 2024
| locale, | ||
| providerCustomization.name, | ||
| name: configData.name ?? 'carbon.super', |
There was a problem hiding this comment.
Let's move to a seperate constant?
There was a problem hiding this comment.
Wil address this in the next PR.
dasuni-30
reviewed
May 15, 2024
| screen, | ||
| providerCustomization.type, | ||
| ); | ||
| type: configData.type ?? BrandingPreferenceTypes.Org, |
There was a problem hiding this comment.
Let's check and nullable checks if required.
There was a problem hiding this comment.
Wil address this in the next PR.
There was a problem hiding this comment.
The config cannot be nullable. Application cannot reach this far, if this is nullable. I think it is expected to break, in case this becomes nullable.
dasuni-30
reviewed
May 15, 2024
| @@ -46,12 +47,17 @@ | |||
| "sass": "^1.75.0", | |||
| "stylelint": "15.1.0", | |||
| "tslib": "^2.6.2", | |||
| "typescript": "^5.4.5" | |||
| "typescript": "5.1.6" | |||
There was a problem hiding this comment.
caret ^ symbol will update to all future minor/patch versions, without incrementing the major version. (npm docs)
since current eslint version supports only upto typescript 5.2, need to avoid this.
dasuni-30
reviewed
May 15, 2024
dasuni-30
approved these changes
May 15, 2024
DonOmalVindula
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Related PRs
Checklist
Security checks