-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add branding #3
Conversation
merge branding objects according to priority
modify get request with type and name parameter
merge branding from console, only if its enabled in the console
26f7079
to
b47a515
Compare
packages/core/src/api/branding.ts
Outdated
const { | ||
baseUrl, | ||
type = BrandingPreferenceTypes.Org, | ||
name = 'WSO2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a fallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
since they are optional properties in the config, added these as a fallback.
* @returns A Promise that resolves to the response from the server. | ||
* @throws {AsgardeoUIException} If the API call fails or when the response is not successful. | ||
*/ | ||
export const brandingText = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const brandingText = async ( | |
export const getBrandingPreferenceText = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with 3951760
packages/core/src/api/branding.ts
Outdated
* @returns {Promise<BrandingPreferenceAPIResponseInterface>} A promise that resolves with the branding preferences. | ||
* @throws {AsgardeoUIException} If an error occurs while fetching the branding preferences or when the response is unsuccessful. | ||
*/ | ||
const branding = async (): Promise<BrandingPreferenceAPIResponseInterface> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const branding = async (): Promise<BrandingPreferenceAPIResponseInterface> => { | |
const getBrandingPreference = async (): Promise<BrandingPreferenceAPIResponseInterface> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with adb5461
* under the License. | ||
*/ | ||
|
||
import {AuthClient} from '../auth-client'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we have space after {
. Let's check why this is not checked in Eslint?
import {AuthClient} from '../auth-client'; | |
import { AuthClient } from '../auth-client'; |
Purpose
Related Issues
Related PRs
Checklist
Security checks