set_omp_num_threads compiling error (utils.cpp) #5
Labels
Comments
rtobar
added a commit
that referenced
this issue
May 6, 2023
The cimg_use_openmp macro is *always* defined by CImg.h, but its *value* is either 0 or 1 depending on whether OpenMP is defined or not. This was breaking compilation on platforms without OpenMP. This fix should address #5. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
|
@gvogler thanks for reporting this. Could you try the fix I just pushed to the |
rtobar
added a commit
that referenced
this issue
May 6, 2023
The cimg_use_openmp macro is *always* defined by CImg.h, but its *value* is either 0 or 1 depending on whether OpenMP is defined or not. This was breaking compilation on platforms without OpenMP. This also uncovered an issue with our code calling Rcpp::cerr instead of Rcpp::Rcerr, which has been fixed now. This fix should address #5. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
|
@gvogler any chance of testing this? We're waiting for feedback to confirm it's all working to then submit a new version to CRAN. If I head nothing in the next 24 hours I'll assume it's all good (it was when testing locally). Thanks! |
|
@rtobar That version compiled without problems. Thanks! |
|
@gvogler that on the |
|
@gvogler thanks for reporting back, we'll merge now and try to upload to CRAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
When compiling in R (macOS, arm64) I am getting the following error:
utils.cpp:336:3: error: use of undeclared identifier 'omp_set_num_threads'; did you mean 'set_omp_num_threads'? omp_set_num_threads(threads); ^~~~~~~~~~~~~~~~~~~ set_omp_num_threads utils.cpp:333:6: note: 'set_omp_num_threads' declared here void set_omp_num_threads(int threads) ^ 1 error generated. make: *** [utils.o] Error 1The text was updated successfully, but these errors were encountered: