keep port if available #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mhoffmann777! First of all, congrats on making your first contribution 😄 Would it be possible for you to write a test(s) for this new functionality? I'd love to see an example of where this might be used 🙂 |
|
Hey, hope this simple test will do it :) |
|
Perfect! Thanks for that, I appreciate it 😄 I made a slight tweak to the code, and added a test (that I probably should have added myself a while ago). I'll get that merged in now and hopefully released over the weekend or early next week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some Docker services running on a host that use different ports. To get the favicon from all services, the fetcher needs to keep the specified port for all URLs.
BTW: This is my very first contribution to a repo ever. :)