Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default_url config option #173

Merged
merged 7 commits into from
Jan 28, 2023
Merged

Conversation

bbredewold
Copy link
Contributor

This PR is to add an option to configure a default_url that is used in the default_short_url generator.

  • Change is backwards-compatible.
  • Change offers more flexibility when for example using a Tenancy package.

@ash-jc-allen
Copy link
Owner

Hey @bbredewold! Thanks for the PR, I love the proposed changes!

Life's a bit hectic at the moment, but I'll try and give this a proper review later in the week 😄

@ash-jc-allen ash-jc-allen merged commit 5d0ba80 into ash-jc-allen:master Jan 28, 2023
@ash-jc-allen
Copy link
Owner

Hey @bbredewold! Huge thanks for this feature. I've just made a few small changes and merged the branch. I'll get this tagged and released today 😄

@bbredewold
Copy link
Contributor Author

Thanks! And thanks for merging it. Appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants