improvement: test out a pattern where we don't use compile time init …

…for changes
ash-project · Mar 1, 2022 · d3f5b8a · d3f5b8a
1 parent e5a1992
commit d3f5b8a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/lib/ash/changeset/changeset.ex b/lib/ash/changeset/changeset.ex
@@ -691,6 +691,7 @@ defmodule Ash.Changeset do
 
     Enum.reduce(changes, changeset, fn
       %{change: {module, opts}}, changeset ->
+        {:ok, opts} = module.init(opts)
         module.change(changeset, opts, %{actor: actor})
 
       %{validation: _} = validation, changeset ->

diff --git a/lib/ash/resource/change/change.ex b/lib/ash/resource/change/change.ex
@@ -53,14 +53,6 @@ defmodule Ash.Resource.Change do
     {:error, "Expected a module and opts, got: #{inspect(other)}"}
   end
 
-  @doc false
-  def transform(%{change: {module, opts}} = change) do
-    case module.init(opts) do
-      {:ok, opts} -> {:ok, %{change | change: {module, opts}}}
-      {:error, error} -> {:error, error}
-    end
-  end
-
   @doc false
   def on(list) do
     list

diff --git a/lib/ash/resource/dsl.ex b/lib/ash/resource/dsl.ex
@@ -312,8 +312,8 @@ defmodule Ash.Resource.Dsl do
       "change relate_actor(:reporter)",
       "change {MyCustomChange, :foo}"
     ],
+    modules: [:change],
     target: Ash.Resource.Change,
-    transform: {Ash.Resource.Change, :transform, []},
     schema: Ash.Resource.Change.action_schema(),
     args: [:change]
   }
@@ -375,8 +375,8 @@ defmodule Ash.Resource.Dsl do
       "change relate_actor(:reporter)",
       "change {MyCustomChange, :foo}"
     ],
+    modules: [:change],
     target: Ash.Resource.Change,
-    transform: {Ash.Resource.Change, :transform, []},
     schema: Ash.Resource.Change.schema(),
     args: [:change]
   }