Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting-started-with-phoenix docs #504

Closed

Conversation

chrishop
Copy link
Contributor

@chrishop chrishop commented Feb 7, 2023

docs: replaced test explaination with LiveView example

Update: 13/02/2023

  • addressed comments to previous draft
  • added section introducing code interface
  • added section integrating the Post resource with a LiveView

docs: 3rd draft of getting-started-with-ash-and-phoenix

Update: 09/02/2023

  • renamed from getting-started-with-phoenix -> getting-started-with-ash-and-phoenix
  • many minor changes in phrasing, formatting.
  • moved text & code block around in their section
  • only show bash command, not the following logs
  • merged API and registry section together
  • extra section showing how to call resource from phoenix

docs: did a rework of initial get-started-with-phoenix draft

Update: 08/02/2023

I was copying the helpdesk example from the pure ash getting started article.
But there was too much extra content which made the guide very long.
Instead I decided the make the resource very minimal, included lots of
information about how to get ash up and running with phoenix and ash postgres.

I'm very welcome to recieve feedback on what I've done so far, I want it to be
as good as it can be.

- Edited AshPostgres.Repo vs Ecto.Repo comment
- Cut 'If using Phoenix 1.7 or higher' section, its only neccessary for ash
  authentication
- Phoenix is now all uppercase
- Ash is now all uppercase
- moved `mix ecto.create` warning to before you run the command
I was copying the helpdesk example from the pure ash getting started article.
But there was too much extra content which made the guide very long.
Instead I decided the make the resource very minimal, included lots of
information about how to get ash up and running with phoenix and ash postgres.

I'm very welcome to recieve feedback on what I've done so far, I want it to be
as good as it can be.
@chrishop chrishop changed the title wip: docgetting-started-with-phoenix docs getting-started-with-phoenix docs Feb 8, 2023
chrishop added a commit to team-alembic/my_ash_phoenix_project that referenced this pull request Feb 8, 2023
@chrishop chrishop marked this pull request as ready for review February 9, 2023 06:58
- renamed from getting-started-with-phoenix -> getting-started-with-ash-and-phoenix
- many minor changes in phrasing, formatting.
- moved text & code block around in their section
- only show bash command, not the following logs
- merged API and registry section together
- extra section showing how to call resource from phoenix
config :ash, :use_all_identities_in_manage_relationship?, false

config :my_ash_phoenix_app,
ash_apis: [MyAshPhoenixApp.Blog]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this part replace the config :my_app, ecto_repos: [MyApp.Repo] line? Or should be in addition to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't replace ecto_repos it is in addition to it. At the top of the code block I say: "Add this to your config:"

chrishop added a commit to team-alembic/ash_phoenix that referenced this pull request Feb 14, 2023
@chrishop chrishop closed this Feb 14, 2023
@chrishop
Copy link
Contributor Author

chrishop commented Feb 14, 2023

Closed in favour of: ash-project/ash_phoenix#70, it fits better in that project.

jimsynz pushed a commit to ash-project/ash_phoenix that referenced this pull request Feb 15, 2023
* docs: derived from ash-project/ash#504

* docs: addressed @sevenseacat comments

* docs: added comment about  usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants