test(Ash.DataLayer.Ets): add unit tests

[TheFirstAvenger]

Couldn't figure out how to create a Filter, so if you could point me in the right direction, I can add that to the PR.

Closes #51

[zachdaniel]

@TheFirstAvenger wow! I'll take a look now :)

[coveralls]

Coverage increased (+0.2%) to 61.224% when pulling ac9acb5 on TheFirstAvenger:mb-51-ets-unit-tests into 8aa94b5 on ash-project:master.

[zachdaniel]

There is so much undocumented at the moment as I work on the elixirconf talk, so how far you got with this is very impressive, thanks so much! A filter is a keyword list, and it looks like this:

Ash.Query.filter(query, name: "zach")
# or more complex
Ash.Query.filter(query, 
  or: [
    [name: [in: ["zach", "mike"]]],
    [name: [not: [eq: "joe"]]]
  ]
)

[zachdaniel]

If you're interested, there are a lot of improvements that could be made to the ETS data layer, like translating filters into matchspecs as opposed to fetching and filtering at runtime. I also added an is_nil predicate that I didn't support in the ETS or Mnesia data layers yet.

Let me know if you'd like to hop on a call some time :)

[TheFirstAvenger]

@zachdaniel good to merge, 100% coverage on the Ets module. I'll take a look at the other stuff you mentioned as I have time. Looking forward to the ElixirConf talk!

[zachdaniel]

Are the changes to the .credo.exs required for your changes to be valid?

[TheFirstAvenger]

no, but those two are legacy checks that no longer apply and produce warnings in the logs if not disabled.

[zachdaniel]

Ah, good to know thanks!

[zachdaniel]

Unless they are necessary, we should remove the .credo.exs changes from this PR.

[zachdaniel]

Looks great!

🚀 Thank you for your contribution! 🚀