Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: allow specifying multi-column foreign keys #180

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

rbino
Copy link
Contributor

@rbino rbino commented Nov 18, 2023

  • improvement: add match_with option on references
  • improvement: add match_type option on references

Submitting this as a draft to get some early feedback given it's my first contribution.

What still needs to be done:

  • Handle the case where with has to be added both due to multitenancy and because it's explicitly defined
  • Cover those cases with tests
  • Add tests for the Transformer check
  • Polymorphic variants of this (I'd be more inclined to leave this to a separate PR probably)

@zachdaniel
Copy link
Contributor

Looks great! 👍

@rbino rbino marked this pull request as ready for review November 18, 2023 15:29
@rbino
Copy link
Contributor Author

rbino commented Nov 18, 2023

@zachdaniel if the polymorphic variants can be implemented in a separate PR this should be ready for review

@zachdaniel
Copy link
Contributor

Looks like some tasks to run:

mix spark.formatter
mix spark.cheat_sheets

as well as a credo check to resolve.

* improvement: add match_with option on references
* improvement: add match_type option on references
@rbino
Copy link
Contributor Author

rbino commented Nov 20, 2023

Fixed all three things

@zachdaniel zachdaniel merged commit 021b7e4 into ash-project:main Nov 20, 2023
48 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants