fix: check for existing installed_extensions/0 in ash_postgres.install #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibarakaiev
force-pushed
the
check-for-existing-installed-extensions-in-installer
branch
from
c4551ad
to
35eb79e
Compare
|
I'm not able to reproduce the failing job locally 🤔. |
zachdaniel
approved these changes
Jun 27, 2024
|
It looks to do the right thing, will be testing the full flow before we release 👍 |
|
🚀 Thank you for your contribution! 🚀 |
ibarakaiev
deleted the
check-for-existing-installed-extensions-in-installer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
This is a minor improvement that checks whether
installed_extensions/0already exists in the repo module before adding it. This is only an issue when an igniter installer is run twice, but I faced it once so just thought it'd be great to catch it.