Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could I set inline or not inline in the file link? #26

Open
Lynn-cc opened this issue Aug 13, 2015 · 3 comments
Open

Could I set inline or not inline in the file link? #26

Lynn-cc opened this issue Aug 13, 2015 · 3 comments

Comments

@Lynn-cc
Copy link

Lynn-cc commented Aug 13, 2015

I think this would be more convenient.
for example: <script src="./js/index.js?inline=true"></script>

@ashaffer
Copy link
Owner

That's not a bad idea, though I think I would prefer to avoid in-band signalling like that (putting it in the url), and also probably opting out would be better rather than opting in. I'd be happy to accept a PR for something along these lines:

<script src='./js/index.js' no-inline></script>

@dylansmith
Copy link

Might be worth using the defer and async attributes of the <script> element to also indicate that the resource should not be inlined.

@ashaffer
Copy link
Owner

@dylansmith Ya, that's definitely true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants