Fixed https://github.com/Ashald/EnvFile/issues/27 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashald
requested changes
Mar 11, 2017
|
|
||
| public static void patchJavaParameters(@NotNull RunConfigurationBase configuration, JavaParameters params, RunnerSettings runnerSettings) throws ExecutionException { |
There was a problem hiding this comment.
The initial design aim for this class was to keep it as generic as possible and use it in concrete implementations. From this perspective rather then keeping methods like patchCommandLine and patchJavaParameters I'd rather go with single method patchEnvironmentVariables (as you essentially did) and move 1-liners from patchCommandLine/patchJavaParameters to concrete implementations.
There was a problem hiding this comment.
Done !
Just for information, I couldn't test it with RubyMine and PyCharm but it should work :)
ashald
added a commit
that referenced
this pull request
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to fix #27. The idea is to use
updateJavaParametersinstead ofpatchCommandLineinIdeaRunConfigurationExtension