Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint 0.26 support #103

Closed
heidiproske opened this issue Jul 12, 2018 · 4 comments
Closed

SwiftLint 0.26 support #103

heidiproske opened this issue Jul 12, 2018 · 4 comments

Comments

@heidiproske
Copy link

heidiproske commented Jul 12, 2018

The latest danger-ruby-swiftlint uses SwiftLint v0.25.1.

A new SwiftLint v0.26.0 is now available.

Motivation for the Update

I'm now using Xcode 9.4 and have a PR that danger fails due to this bug realm/SwiftLint#2231. Would like to get my PR merged so need to get this resolved and I'm hoping that with the latest SwiftLint it will go away.

I did try do a workaround by using swiftlint:disable identifier_name but then I get a local Xcode error saying Superfluous Disable Command Violation: SwiftLint rule 'identifier_name' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command) so I really need the latest SwiftLint :)

What Next?

Based on previous PRs to this repo, it looks like it's usually just a 1 liner to bump the version as long as there are no breaking changes to the CLI from SwiftLint. Based on the release notes for Swiftlint v0.26.0, the only breaking change is that:

SwiftLint now requires Swift 4.0 or higher to build.

which shouldn't affect danger-ruby-swiftlint right?

I don't mind giving this a shot but not sure what to do. Do I just do something similar to how this PR bumped the version?
https://github.com/ashfurrow/danger-ruby-swiftlint/pull/36/files

@thii
Copy link
Collaborator

thii commented Jul 13, 2018

@heidiproske I just updated the managed SwiftLint version to 0.26.0 in #104, but you can always use the SWIFTLINT_VERSION environment variable to override the default installed version.

@heidiproske
Copy link
Author

heidiproske commented Jul 13, 2018

Aaaah thank you @thii !

Btw, I'm using the swiftlint binary that ships with the danger-swiftlint gem (trying to move away from cocoapods) so I don't think I can just override the environment variable :)

@ashfurrow
Copy link
Owner

This has been released to RubyGems as 0.17.1 and should be available for general use. Thanks @heidiproske for the great, detailed issue and @thii for the fix!

@heidiproske
Copy link
Author

I just tested this on several repos and the erroneous lint error bug for case enums is no longer happening, thank you @thii & @ashfurrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants