Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gardening. #trivial #12

Merged
merged 4 commits into from
May 1, 2018
Merged

Gardening. #trivial #12

merged 4 commits into from
May 1, 2018

Conversation

sunshinejr
Copy link
Collaborator

So I'm preparing my DangerXiblint plugin and was doing it anyway, so figured I could update everything in here as well! Let me know how it looks.

  • Move to CircleCI 2
  • Update deps (Danger 0.4.0, Marathon 3.0.0, Releases 3.0.0)
  • Update codebase to Swift 4.1 (flatMap -> compactMap)
  • Fix issue with setting the fixed local path to your project in Tests (using #file and deleting few last path components 馃槈)

@ashfurrow-peril
Copy link

ashfurrow-peril bot commented May 1, 2018

It looks like code was changed without adding anything to the Changelog.

Generated by 馃毇 dangerJS

@sunshinejr sunshinejr changed the title Gardening. Gardening. #trivial May 1, 2018
Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 馃憤 Thanks!

// This is for me, testing. Uncomment if you're running tests locally.
// FileManager.default.changeCurrentDirectoryPath("/Users/ash/bin/danger-swiftlint")
let localPath = URL(string: #file)!.deletingLastPathComponent(2).absoluteString
FileManager.default.changeCurrentDirectoryPath(localPath)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@ashfurrow ashfurrow merged commit 327c541 into master May 1, 2018
@ashfurrow ashfurrow deleted the patch/gardening branch May 1, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants