added browser target for webpack, browserify #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be done neatly with |
|
oh, I didn't know about TypedArray. That would probably be the correct way to implement it then. I didn't find any browser-only implementations for crc-32, though there were some isomorphic implementations I found when I was looking a while ago... I just made this small change on my fork since I needed a quick fix for the browser at that time. Feel free to close the PR if you think it's not necessary. FWIW, webpack and browserify include this shim by default so this shim would be getting included anyway for someone using webpack/browserify in their project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
browsertarget in package.json is supported by browserifyand webpack
The buffer module is also used by both bundlers to provide a shim for the node
Buffer.