Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul package #17

Merged
merged 1 commit into from
Oct 5, 2019
Merged

overhaul package #17

merged 1 commit into from
Oct 5, 2019

Conversation

ashi009
Copy link
Owner

@ashi009 ashi009 commented Oct 4, 2019

This CL updates this package completely:

  • add additional files to .npmignore.
  • add coveralls badge in README.
  • fix lint errors in README.
  • use const/let instead of vars.
  • use up-to-date TypedArray and Buffer APIs.
  • add curly brackets to single-line if/for.
  • make the package always safe to require.
    Instead of throwing at require time, it now exports a calculate() that throws.
  • remove engine requirement from package.json.
  • replace blanket, travis-conv with nyc and coveralls.
  • replace package-lock.json with yarn.lock.
  • specify dev dep versions to avoid future CI failures.
  • test against node 6, 8, 10 and 12 on Travis CI.
  • bump to v2.0.0, as the minimal node version required is 6.

@ashi009 ashi009 marked this pull request as ready for review October 4, 2019 14:36
@ashi009 ashi009 changed the title WIP: package overhaul Package overhaul Oct 4, 2019
@ashi009 ashi009 changed the title Package overhaul overhaul package Oct 4, 2019
@f5io
Copy link

f5io commented Oct 4, 2019

Is the CI set to publish on PR? There's been a publish to npm 2 hours ago of 1.0.6. Its broken all of @google-cloud/storage.

@ashi009
Copy link
Owner Author

ashi009 commented Oct 4, 2019

Is the CI set to publish on PR? There's been a publish to npm 2 hours ago of 1.0.6. Its broken all of @google-cloud/storage.

nop. Publishing is not in the CI.

Could you elaborate on what's broken? Given that v1.0.6 only changes the version of an optional dependency.

@f5io
Copy link

f5io commented Oct 4, 2019

See #19

We might be an edge-case but if fast-crc32c@1.0.6 is used by hash-stream-validation@0.2.1 then @google-cloud/storage fails completely with the error in the issue.

@ashi009 ashi009 merged commit 5b2917d into master Oct 5, 2019
@ashi009 ashi009 deleted the cl/package-overhaul branch October 5, 2019 04:49
This was referenced Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants