Handle JSON parse errors to prevent watch from crashing if a non-JSON request body is received. #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When using lambda-local in
--watch
mode, if you post and empty body or body containing invalid JSON, the lambda-local process crashes.Example output when posting empty body:
(lambda-local process crashes after this error occurs)
Example output when posting body that is not valid JSON:
(lambda-local process crashes after this error occurs)
How this PR fixes the problem
This PR adds a try/catch around the
JSON.parse(body)
call to handle exceptions that can occur while parsing the body and returning them through the callback.(It also adds a return after the callback for missing payload.event so that it doesn't trigger multiple callbacks in that case)