Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly mirror lambda's behaviour when synchronously returning #220

Merged
merged 2 commits into from Feb 15, 2022

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Feb 15, 2022

When a Lambda returns its result synchronously (as opposed to as a Promise, or via the callback / context.succeed), Lambda will ignore the result. This PR makes a small update, so that behaviour is mirrored.

Screenshot 2022-02-15 at 10 20 14

Screenshot 2022-02-15 at 10 20 20

Copy link
Collaborator

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR ! I'll try to make a new release tonight

@gpotter2 gpotter2 merged commit 8e5afac into ashiina:develop Feb 15, 2022
@gpotter2
Copy link
Collaborator

gpotter2 commented Mar 8, 2022

Sorry for the delay, 2.0.2 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants