Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom text styles, buttons text size and background color #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Mar 29, 2019

What this PR does

  • Separate textSize attribute for the text view and +/- buttons (controls)
  • Add textStyle to buttons
  • Add textSize to buttons
  • Add a backgroundColor separately to each of the buttons

Similar Issues Solved

Solves #15, #8, #20,

Screenshots

image

@ghost ghost changed the title Add support for more custom styles Add support for custom text styles, buttons text size and background color Mar 29, 2019
Separate size attributes for the textview and +/- buttons
Copy link
Owner

@ashik94vc ashik94vc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm restarting work on this library and I'm establishing some coding standards here. Can you fix the PR once the work is done? I want to make this library much more open to contributions without my intervention.

@ghost
Copy link
Author

ghost commented May 29, 2019

I'll do

@@ -19,6 +22,7 @@

/**
* Created by Ashik Vetrivelu on 10/08/16.
* Modified by Dennis Murage on 24/03/2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove meta data

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants