New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tn/add export functionality #831
Conversation
frontend/webpack.config.js
Outdated
@@ -60,6 +61,11 @@ module.exports = (env, argv) => ({ | |||
filename: 'main-[contenthash].css', | |||
chunkFilename: '[chunkhash].css', | |||
}), | |||
new webpack.DefinePlugin({ | |||
'process.env': { | |||
'ENABLE_EVIDENCE_EXPORT': process.env.ENABLE_EVIDENCE_EXPORT == 'true', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thought that I just had is that I could include this global flag on the backend and incorporate it into UserCanExportData
, since most of the global flags are on the backend and that way all of the logic for allowing a user to export is on the backend. I'll do that tomorrow morning
Overall looks good and works. A few changes:
|
For code snippets, I added:
Other:
|
Those changes look good. If C/C++ are the only case where the extension isn't clear that seems fine to just use One other change, can we remove the extra tag information (eg. color) and just make it an array of the tags themselves (eg. |
Also, can we change the key from |
Got it! I've
|
I think there was a misunderstanding with the tags. Can you just extract all the names from the tags and make it an array of strings (of the names) rather than an array of objects. |
oh gotcha - I just reread your original message |
Adds an export feature per the following features
A few things to note:
Screen.Recording.2023-05-08.at.2.00.41.PM.mov
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.