Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-delete and table delete on evidence table #53

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

JoelAtDeluxe
Copy link
Contributor

This PR provides two new abilities.
First, it enables multi-select on the evidence table, either via a ctrl+click (or shift+click) or by dragging the mouse over multiple rows. When multiple items are selected AND the delete context menu is selected, all of the selected pieces of evidence will be removed. A warning prompt appears before deletion, and an error prompt appears after deletion, if some of the files could not be deleted.

Second, this PR adds the ability to remove all of the currently visible rows in the table, which effectively allows for deleting by whole groups of evidence based on a common condition -- e.g. belonging to a certain operation. Again, a prompt appears before, and conditionally after, in much the same was as a standard item delete.

Lastly, this will also remove directories if the last piece of evidence is removed from that directory.

Note that the error condition for deletes has changed. Previously, a message would popup indicating exactly which file was not deleted. Now, we instead attempt to write a file with a list of all non-deleted files in that batch, and we will instead point the user to this file (if it is written)

Addresses Issues: #48, #49

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@jrozner jrozner merged commit f386349 into master Sep 22, 2020
@jrozner jrozner deleted the js-enable-multiselect branch October 6, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local operation deletion Multiselect deletion in the evidence manager
2 participants