Replace 'pm list packages' with 'dumpsys package' #130

A-YATTA · 2020-12-24T16:30:42Z

In some cases, the command 'pm list packages' will not list all enabled third party packages (same for -e and -s).
https://stackoverflow.com/questions/63416599/adb-shell-pm-list-packages-missing-some-packages

codeclimate · 2020-12-24T16:31:32Z

adbe/adb_enhanced.py

+    cmd = 'dumpsys package'
+    grep_cmd = 'grep -Po "Package \[\K[^\]]+"'
+    apps_list = execute_adb_shell_command(cmd, piped_into_cmd=grep_cmd)
+    # packages = _get_all_packages(cmd)


Remove this commented out code.

codeclimate · 2020-12-24T16:31:33Z

adbe/adb_enhanced.py

+        lambda p : p not in runtime_granted_permissions and
+                   p not in runtime_denied_permissions and
+                   p not in install_time_granted_permissions and
+                   p not in install_time_denied_permissions, requested_permissions))


Continuation line unaligned for hanging indent

codeclimate · 2020-12-24T16:31:33Z

adbe/adb_enhanced.py

        _ASYNCIO_AVAILABLE = True
-    except ImportError:
+    except ImportError :


Whitespace before ':'

Please revert

codeclimate · 2020-12-24T16:31:33Z

adbe/adb_enhanced.py

        # This is to deal with python versions below 3.5
        _ASYNCIO_AVAILABLE = False
-else:
+else :


Whitespace before ':'

Please revert

codeclimate · 2020-12-24T16:31:33Z

adbe/adb_enhanced.py

    _ASYNCIO_AVAILABLE = False

-try:
+try :


Whitespace before ':'

ashishb · 2020-12-24T18:31:05Z

adbe/adb_enhanced.py

-        if activity_name.startswith('.'):
-            activity_name = '%s%s' %(app_name, activity_name)
-        return app_name, activity_name
+        if line.startswith('mFocusedApp'):


Is this change intentional? I think this is the exact code that I removed in 69bb243

Nope, I forked the master branch.

Just do a git pull origin master in that case. Your branch has become stale. I changed this code <24 hours ago.

ashishb · 2020-12-24T18:31:54Z

adbe/adb_enhanced.py

-    cmd = 'pm list packages'
-    packages = _get_all_packages(cmd)
-    print('\n'.join(packages))
+    # The command "pm list packages -e" does not return all installed and enabled Apps, the alternative is to use


So what exactly does pm list packages -e miss? Disabled apps?

pm list packages -e for some unknown reason does not list some enabled apps.
-e should show all enabled Apps including system Apps which is not the case as discussed in the thread: https://stackoverflow.com/questions/63416599/adb-shell-pm-list-packages-missing-some-packages

Thanks. It is fine if we don't know the underlying cause. Add this StackOverflow thread in the code comments as well.

I saw that the regex is reported as an anomaly by DeepSource Python, Can we replace it by this one dumpsys package | grep "Package \[" | cut -d "\[" -f2 | cut -d "\]" -f1.

The new code is fine. Just confirm that cut command's arguments are the same on both Linux and Mac.

It should be the same (https://superuser.com/questions/179368/how-does-macs-command-line-compare-to-linux), unfortunately I do not have a Mac to test. Can someone else confirm that please ?

I got cut: bad delimiter as an error on Mac OS. How about we do this parsing in Python instead? That's much more portable as well.

Yes sure, I will update it.

ashishb · 2020-12-24T18:32:30Z

adbe/adb_enhanced.py

@@ -1562,43 +1579,3 @@ def switch_screen(switch_type):
                                 "screen control operation. Error: %s" % e)

    return o
-


Please rebase your code to avoid reverting this addition.

Sure. Sorry for that!

No worries.

adbe/adb_enhanced.py

ashishb

Thanks for your contribution.

A-YATTA · 2020-12-24T18:48:14Z

Command output:

$ adbe apps list all
com.android.cts.priv.ctsshim
com.android.internal.display.cutout.emulation.corner
com.android.internal.display.cutout.emulation.double
com.android.providers.telephony
com.android.dynsystem
com.android.providers.calendar
com.android.providers.media
com.android.theme.icon.square
com.android.internal.systemui.navbar.gestural_wide_back
....

ashishb

Approved pending the addition of StackOverflow thread as a comment for future reference.

codeclimate · 2021-01-05T18:27:36Z

Code Climate has analyzed commit 4115230 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Security	5

View more on Code Climate.

ashishb · 2021-01-06T09:55:43Z

So, I checked dumpsys package | grep "Package \[" today. It includes some duplicates but even after removing all duplicates I saw 420 packages as opposed to 403 packages from adb shell pm list packages, I do see some weird and interesting services listed. So, yeah, let's merge this after de-duplicating the list.

ashishb · 2021-01-06T10:29:00Z

adbe/adb_enhanced.py

+    return_code, result, _ = execute_adb_shell_command2(cmd)
+    if return_code != 0:
+        print_error_and_exit('Command "%s" failed, something is wrong' % cmd)
+    all_apps = re.findall(pattern_packages, result)


This is not printing the results. I will fix that in #135

Replace 'pm list packages' with 'dumpsys package'

719d485

codeclimate bot reviewed Dec 24, 2020

View reviewed changes

Delete useless whitespaces

7424554

ashishb reviewed Dec 24, 2020

View reviewed changes

adbe/adb_enhanced.py Outdated Show resolved Hide resolved

ashishb reviewed Dec 24, 2020

View reviewed changes

adbe/adb_enhanced.py Show resolved Hide resolved

ashishb reviewed Dec 24, 2020

View reviewed changes

Update list all apps

3d8b690

ashishb approved these changes Dec 24, 2020

View reviewed changes

A-YATTA closed this Dec 24, 2020

A-YATTA reopened this Dec 24, 2020

Replace grep with Python re regex

4115230

ashishb merged commit ac04b83 into ashishb:master Jan 6, 2021

ashishb reviewed Jan 6, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace 'pm list packages' with 'dumpsys package' #130

Replace 'pm list packages' with 'dumpsys package' #130

A-YATTA commented Dec 24, 2020

codeclimate bot Dec 24, 2020

codeclimate bot Dec 24, 2020

codeclimate bot Dec 24, 2020

ashishb Dec 26, 2020

codeclimate bot Dec 24, 2020

ashishb Dec 26, 2020

codeclimate bot Dec 24, 2020

ashishb Dec 24, 2020

A-YATTA Dec 24, 2020

ashishb Dec 24, 2020

ashishb Dec 24, 2020

A-YATTA Dec 24, 2020

ashishb Dec 24, 2020

A-YATTA Dec 25, 2020

ashishb Dec 26, 2020

A-YATTA Dec 26, 2020

ashishb Dec 26, 2020

A-YATTA Dec 27, 2020

ashishb Dec 24, 2020

A-YATTA Dec 24, 2020

ashishb Dec 24, 2020

ashishb left a comment

A-YATTA commented Dec 24, 2020

ashishb left a comment

codeclimate bot commented Jan 5, 2021

ashishb commented Jan 6, 2021 •

edited

ashishb Jan 6, 2021

		@@ -1562,43 +1579,3 @@ def switch_screen(switch_type):
		"screen control operation. Error: %s" % e)

		return o

Replace 'pm list packages' with 'dumpsys package' #130

Replace 'pm list packages' with 'dumpsys package' #130

Conversation

A-YATTA commented Dec 24, 2020

codeclimate bot Dec 24, 2020

Choose a reason for hiding this comment

codeclimate bot Dec 24, 2020

Choose a reason for hiding this comment

codeclimate bot Dec 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot Dec 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot Dec 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashishb left a comment

Choose a reason for hiding this comment

A-YATTA commented Dec 24, 2020

ashishb left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jan 5, 2021

ashishb commented Jan 6, 2021 • edited

Choose a reason for hiding this comment

ashishb commented Jan 6, 2021 •

edited