Don't use signed here, hash computation can overflow. (apache#1612)

ashishk-1 · Aug 8, 2017 · 5fe092c · 5fe092c
1 parent aadbc70
commit 5fe092c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/net/instaweb/rewriter/server_context_test.cc b/net/instaweb/rewriter/server_context_test.cc
@@ -1278,7 +1278,7 @@ TEST_F(BeaconTest, BasicPcacheSetup) {
 TEST_F(BeaconTest, HandleBeaconRenderedDimensionsofImages) {
   GoogleString img1 = "http://www.example.com/img1.png";
   GoogleString hash1 = IntegerToString(
-      HashString<CasePreserve, int>(img1.c_str(), img1.size()));
+      HashString<CasePreserve, unsigned>(img1.c_str(), img1.size()));
   options()->EnableFilter(RewriteOptions::kResizeToRenderedImageDimensions);
   RenderedImages rendered_images;
   RenderedImages_Image* images = rendered_images.add_image();
@@ -1301,9 +1301,9 @@ TEST_F(BeaconTest, HandleBeaconCritImages) {
   GoogleString img1 = "http://www.example.com/img1.png";
   GoogleString img2 = "http://www.example.com/img2.png";
   GoogleString hash1 = IntegerToString(
-      HashString<CasePreserve, int>(img1.c_str(), img1.size()));
+      HashString<CasePreserve, unsigned>(img1.c_str(), img1.size()));
   GoogleString hash2 = IntegerToString(
-      HashString<CasePreserve, int>(img2.c_str(), img2.size()));
+      HashString<CasePreserve, unsigned>(img2.c_str(), img2.size()));
 
   StringSet critical_image_hashes;
   critical_image_hashes.insert(hash1);