Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTTP request stack swappable #7

Closed
dblock opened this issue Oct 4, 2017 · 2 comments
Closed

Make HTTP request stack swappable #7

dblock opened this issue Oct 4, 2017 · 2 comments
Labels
enhancement

Comments

@dblock
Copy link
Collaborator

dblock commented Oct 4, 2017 •
edited
Loading

Bring your own HTTP, inspired by https://github.com/codegram/hyperclient#api-client.

Or maybe replace HTTP for Faraday?
@dblock dblock mentioned this issue Oct 5, 2017
Closed
@ashkan18
Copy link
Owner

ashkan18 commented Oct 9, 2017

going to switch our HTTP layer with graphql-client so we can also benefit from their schema validation and handle #2

@dblock
Copy link
Collaborator Author

dblock commented Oct 18, 2017

You can now do this by subclassing Graphlient::Client and overriding http, so really there's only one more step to allow passing http in options to swap the default implementation.

This was referenced Oct 26, 2017
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @ashkan18