Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing #401

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Fix typing #401

merged 1 commit into from
Jul 16, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Jul 16, 2022

What does this PR do?

Improves typing:

  • Fixes incorrect typing in tasks.
  • Adds missing typing to some utils methods.
  • Removes typing from datamodule for consistency with the lightning module.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve added bug Something isn't working enhancement New feature or request labels Jul 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #401 (c1b6ed6) into main (36bc41f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files          11       11           
  Lines         351      351           
=======================================
  Hits          291      291           
  Misses         60       60           
Impacted Files Coverage Δ
src/datamodules/mnist_datamodule.py 94.73% <100.00%> (ø)
src/tasks/eval_task.py 92.30% <100.00%> (ø)
src/tasks/train_task.py 95.12% <100.00%> (ø)
src/utils/utils.py 64.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bc41f...c1b6ed6. Read the comment docs.

@ashleve ashleve merged commit 9dbef77 into main Jul 16, 2022
@ashleve ashleve deleted the fix-typing branch July 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants