Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate job for windows in CI test worfklow #422

Merged
merged 5 commits into from
Aug 20, 2022
Merged

Add separate job for windows in CI test worfklow #422

merged 5 commits into from
Aug 20, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Aug 20, 2022

What does this PR do?

Adds separate job for windows in Tests workflow.

Makes Tests workflow install sh package if os is not windows.

Otherwise shell tests wouldn't be executed.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve added the bug Something isn't working label Aug 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #422 (96f2ec6) into main (8987b23) will increase coverage by 14.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #422       +/-   ##
===========================================
+ Coverage   68.66%   82.90%   +14.24%     
===========================================
  Files          11       11               
  Lines         351      351               
===========================================
+ Hits          241      291       +50     
+ Misses        110       60       -50     
Impacted Files Coverage Δ
src/tasks/train_task.py 95.12% <0.00%> (+2.43%) ⬆️
src/utils/utils.py 64.48% <0.00%> (+14.01%) ⬆️
src/utils/rich_utils.py 82.60% <0.00%> (+50.00%) ⬆️
src/train.py 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashleve ashleve changed the title Make test workflow install sh if bash is available Add separate job for windows in CI test worfklow Aug 20, 2022
@ashleve ashleve merged commit c4dde48 into main Aug 20, 2022
@ashleve ashleve deleted the fix-tests branch August 20, 2022 13:24
@ashleve ashleve added maintenance and removed bug Something isn't working labels Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants