Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments #429

Merged
merged 6 commits into from
Aug 24, 2022
Merged

Improve comments #429

merged 6 commits into from
Aug 24, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Aug 24, 2022

What does this PR do?

Improves comments in train.py and eval.py.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 馃檭

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #429 (4b7a3d0) into main (1ad3c2e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           9        9           
  Lines         344      344           
=======================================
  Hits          291      291           
  Misses         53       53           
Impacted Files Coverage 螖
src/eval.py 90.32% <100.00%> (酶)
src/train.py 95.83% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashleve ashleve merged commit e0674f2 into main Aug 24, 2022
@ashleve ashleve deleted the improve-comments branch August 24, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants