Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename step() to model_step() for compatibility with recent lightning release #472

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Dec 7, 2022

What does this PR do?

Renames model.step() to model.model_step() for compatibility with recent lightning release.

(lightning is now using step() as its own internal function, so we can't override it)

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 馃檭

@ashleve ashleve added the bug Something isn't working label Dec 7, 2022
@ashleve ashleve merged commit d1fdeef into main Dec 7, 2022
@ashleve ashleve deleted the fix-tests branch December 7, 2022 14:11
@ashleve ashleve added maintenance and removed bug Something isn't working labels Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant