Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade accuracy metric initialization to recent torchmetrics release #475

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Dec 7, 2022

What does this PR do?

Adds task arg to accuracy metric for compatibility with recent torchmetrics release.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve added the bug Something isn't working label Dec 7, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.70% // Head: 84.70% // No change to project coverage 👍

Coverage data is based on head (5e1de61) compared to base (d1fdeef).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files           9        9           
  Lines         353      353           
=======================================
  Hits          299      299           
  Misses         54       54           
Impacted Files Coverage Δ
src/models/mnist_module.py 98.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashleve ashleve changed the title Add task arg to accuracy metric Add task and num_classes args to accuracy metric Dec 7, 2022
@ashleve ashleve merged commit 18d6838 into main Dec 7, 2022
@ashleve ashleve deleted the fix-accuracy-metric branch December 7, 2022 14:56
@ashleve ashleve changed the title Add task and num_classes args to accuracy metric Upgrade accuracy metric initialization (#475) Dec 31, 2022
@ashleve ashleve changed the title Upgrade accuracy metric initialization (#475) Upgrade accuracy metric initialization Dec 31, 2022
@ashleve ashleve changed the title Upgrade accuracy metric initialization Upgrade accuracy metric initialization to recent torchmetrics release Dec 31, 2022
@ashleve ashleve added maintenance and removed bug Something isn't working labels Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants