Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit comment/warning to training_epoch_end() #486

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Dec 18, 2022

What does this PR do?

Adds explicit comment/warning to training_epoch_end() hook.

Fixes #458

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve added documentation Improvements or additions to documentation cosmetic best-practices and removed documentation Improvements or additions to documentation labels Dec 18, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.46% // Head: 84.46% // No change to project coverage 👍

Coverage data is based on head (8b71c3f) compared to base (75b44ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files           9        9           
  Lines         354      354           
=======================================
  Hits          299      299           
  Misses         55       55           
Impacted Files Coverage Δ
src/models/mnist_module.py 98.41% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overloading training_epoch_end may not be a good idea without an explicit warning
2 participants