Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hydra version to 1.3 in tests #542

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Set hydra version to 1.3 in tests #542

merged 1 commit into from
Feb 25, 2023

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Feb 25, 2023

What does this PR do?

Sets hydra version in tests to 1.3 as it should be (I forgot to refactor this before).

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@82f31b9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #542   +/-   ##
======================================
  Coverage       ?   83.71%           
======================================
  Files          ?        9           
  Lines          ?      350           
  Branches       ?        0           
======================================
  Hits           ?      293           
  Misses         ?       57           
  Partials       ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashleve ashleve merged commit 81fafde into dev Feb 25, 2023
@ashleve ashleve deleted the fix-tests branch February 25, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants