Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to Lightning 2.0 #548

Merged
merged 10 commits into from
Mar 18, 2023
Merged

Update template to Lightning 2.0 #548

merged 10 commits into from
Mar 18, 2023

Conversation

johnnynunez
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 ⚠️

Comparison is base (adc6afe) 83.80% compared to head (4cfeeed) 83.66%.

❗ Current head 4cfeeed differs from pull request most recent head 7778d41. Consider uploading reports for the commit 7778d41 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #548      +/-   ##
==========================================
- Coverage   83.80%   83.66%   -0.14%     
==========================================
  Files           9        9              
  Lines         352      349       -3     
==========================================
- Hits          295      292       -3     
  Misses         57       57              
Impacted Files Coverage Δ
src/data/mnist_datamodule.py 94.73% <100.00%> (ø)
src/eval.py 90.32% <100.00%> (ø)
src/models/mnist_module.py 98.41% <100.00%> (-0.05%) ⬇️
src/train.py 95.91% <100.00%> (+0.08%) ⬆️
src/utils/pylogger.py 100.00% <100.00%> (ø)
src/utils/rich_utils.py 82.60% <100.00%> (ø)
src/utils/utils.py 59.80% <100.00%> (-0.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnnynunez
Copy link
Contributor Author

@ashleve it's important to change pytorch-lightning to lightning

@ashleve
Copy link
Owner

ashleve commented Mar 17, 2023

@johnnynunez Thanks for helping with the update!

@ashleve
Copy link
Owner

ashleve commented Mar 17, 2023

I reverted the pre-commit changes because they were not relevant to updating Lightning and want to address them in a separate pull request.

@ashleve ashleve changed the base branch from main to dev March 17, 2023 18:33
@ashleve
Copy link
Owner

ashleve commented Mar 17, 2023

WIll also address pytorch compilation in another PR

@ashleve ashleve changed the title lightning 2.0 Update template to Lightning 2.0 Mar 18, 2023
@ashleve ashleve merged commit 193d7de into ashleve:dev Mar 18, 2023
ashleve added a commit that referenced this pull request Mar 18, 2023
* Support for logging with Aim (#534)

* Update template to Lightning 2.0 (#548)

* Update pre-commit hooks (#549)

* Refactor utils (#541)

* Add option for pytorch 2.0 model compilation (#550)

* Update `README.md` (#551)

---------

Co-authored-by: Mattie Tesfaldet <mattie@meta.com>
Co-authored-by: Johnny <johnnynuca14@gmail.com>
@ashleve ashleve added dependencies Pull requests that update a dependency file maintenance labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants