Fix for array bounds issue for hydraulic conductivity in var_derive.f90. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good; this change would apply to the summa CH-earth develop branch too (https://github.com/CH-Earth/summa/tree/develop) -- so it's been around a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ashleymedin - This PR fixes an array going out of bounds in var_derive.f90. Specifically, mLayerSatHydCondMP was going out of bounds for iLayer=nSnow around line 347. In this update, a surrounding if statement has been updated to resolve the issue.
With this update, BE_Debug now runs the laugh tests without detecting any segmentation faults or array bounds violations. Stack memory is no longer being corrupted by invalid array element access.
Make sure all the relevant boxes are checked (and only check the box if you actually completed the step):