Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default encoding of utf8. #67

Closed
wants to merge 1 commit into from
Closed

Add default encoding of utf8. #67

wants to merge 1 commit into from

Conversation

cgc
Copy link

@cgc cgc commented Jun 11, 2014

was wondering if you'd be interested in restoring the previous default for getCodec.

@ashtuchkin
Copy link
Owner

Hi Carlos! Why do you think it is needed? What is your use case? I see something like this str = iconv.decode(buf) to be misleading.

@cgc
Copy link
Author

cgc commented Jun 12, 2014

the only compelling reason I've got is backwards compatability. in any case, I totally respect asking users to be explicit.

@ashtuchkin
Copy link
Owner

Yes, I think explicitness here is better for the users. Thank you for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants