Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message when deleting a log that does not exist #5

Open
Ashuh opened this issue Apr 16, 2022 · 1 comment
Open

Wrong error message when deleting a log that does not exist #5

Ashuh opened this issue Apr 16, 2022 · 1 comment

Comments

@Ashuh
Copy link
Owner

Ashuh commented Apr 16, 2022

When trying to delete a log that does not exist using a large LOG_INDEX value, the following error is shown:

image.png

However, the person index is valid. The problem lies with the LOG_INDEX instead.

@soc-se-bot
Copy link

soc-se-bot commented Apr 19, 2022

Team's Response

Both arise due to integer overflow causing indices to become valid.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Different error message for different index values

Trying to use the editfriend command on index 100 which does not exist results in the following error:

image.png

Doing the same on index 100000000000000 results in the following error instead:

image.png


[original: nus-cs2103-AY2122S2/pe-interim#66] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: Although both bugs may be caused by integer overflow, they are from 2 different commands. Hence, they have to be fixed independently of one another and are not duplicates.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants