-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring #219
Code refactoring #219
Conversation
dhruvkrishnavaid
commented
Jun 21, 2022
•
edited
edited
- Fixed inconsistent text alignment in header
- Fixed console errors (no key provided by rendering methods and invalid DOM properties).
|
`npm audit fix`
@ashutosh1919 In the last commit, I had updated |
Node.js version 10.x is already EOL, so there should not be much concern in updating Node.js to 14.x or 16.x |
@dhruvkrishnavaid I see a commit regarding preact and all which you did not mention in the comments. Why do we have these many changes in one PR? The issues you mentioned are real and I would like to merge them but the PR is too big and is very difficult to review. Can you divide it and raise smaller PRs, please. |
@saiteja13427 The commits related to Preact were mentioned in my old PR (#172) and were reverted in commits |
@dhruvkrishnavaid Alright, but still this is too big of a PR. Please divide it and raise smaller PRs. |
Most of the files listed in the Files changed section are the updated font-awesome assets located at |
Ok, I'll raise separate PRs with smaller changes. |
Thanks man @dhruvkrishnavaid |