Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect time period offsets for saved presets #197

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

fix for offset corrections introduced in the following commits

  1. b449ef6
  2. 8ef502d
  3. 11eb63e#diff-db23b0e75244cdeb8ead7184bb06cb7cR15-R71

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone Jun 14, 2020
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #197 into master will decrease coverage by 1.45%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   87.33%   85.88%   -1.46%     
==========================================
  Files          22       19       -3     
  Lines        1153     1020     -133     
  Branches      131      101      -30     
==========================================
- Hits         1007      876     -131     
+ Misses         75       73       -2     
  Partials       71       71              
Flag Coverage Δ
#android 85.88% <75.00%> (-0.06%) ⬇️
#cast_receiver ?
#ui_tests 60.84% <25.00%> (-0.09%) ⬇️
#unit_tests 40.07% <75.00%> (-6.81%) ⬇️
Impacted Files Coverage Δ
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 92.85% <75.00%> (-2.02%) ⬇️
cast-receiver/src/status_ui_handler.ts
cast-receiver/src/library.mock.js
cast-receiver/src/player_manager.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 711278d...4967bc3. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 275d660 into master Jun 14, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/time-period-serialization branch June 14, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant