Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about adding plugin in GoCD hosted on K8s #99

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Add information about adding plugin in GoCD hosted on K8s #99

merged 2 commits into from
Oct 2, 2019

Conversation

mohamednajiullah
Copy link
Contributor

This PR should help people who have their GoCD setup hosted on Kubernetes to add this plugin to their instance.

It contains information on how to add the plugin jar file and also on how to mount the config file.

@mohamednajiullah
Copy link
Contributor Author

The PR only updates the README.md. I don't know why the CI check is failing.

Is it possible to retrigger it?

Copy link
Owner

@ashwanthkumar ashwanthkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR. You might want to add some spaces between ###... heading markups and the text for the Github to render it properly.

@ashwanthkumar
Copy link
Owner

One the JDK that this project was using is no longer supported on Travis. I've updated the matrix, once you fix the markup the build should go green post that.

@mohamednajiullah
Copy link
Contributor Author

Sorry about that. I used an editor that showed that the formatting was proper.

I've corrected it. Please confirm.

@ashwanthkumar
Copy link
Owner

Merging this. Thanks!

@ashwanthkumar ashwanthkumar merged commit 8164e32 into ashwanthkumar:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants