Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails backend #1

Merged
merged 4 commits into from
May 13, 2023
Merged

Rails backend #1

merged 4 commits into from
May 13, 2023

Conversation

asifaminisonline
Copy link
Owner

### Hello, in this feature branch I

Highlights

  • Created a new Rails API app called Hello-rails-backend.
  • The project has a Postgres database set up.
  • Created a table for storing messages and add 5 different greetings.
  • Created an API endpoint that selects a random greeting from the table.
  • Link to front End
  • Link to front end PR

Copy link

@cynthiainga cynthiainga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asifaminisonline,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • The app works as expected ✔️
  • Descriptive PR ✔️
  • The route is created ✔️
  • Correct Gitflow ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@asifaminisonline asifaminisonline merged commit 4ff12aa into dev May 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants