You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
I noticed this actually breaks when trying to send a RequestInterface implementation created with guzzlehttp/psr7 via your HttpClient, because they are checking the argument with is_string() inside their Uri implementation. https://github.com/guzzle/psr7/blob/master/src/Uri.php#L383
The text was updated successfully, but these errors were encountered:
kaiwa
changed the title
Psr incompatibility in AbstractTransport
Psr incompatibility in AbstractTransport Uri handling
Aug 6, 2015
You will notice that NULL is allowed in phly Uri::withFragment(), so I think the is_string condition in withPath() and withQuery() is a misunderstand of Psr7.
Hi,
NULL is not allowed as argument to
UriInterface::withPath()
,UriInterface::withQuery()
andUriInterface::withFragment()
according to https://github.com/php-fig/http-message/blob/master/src/UriInterface.php and implemented in AbstractTransport.php:I noticed this actually breaks when trying to send a RequestInterface implementation created with
guzzlehttp/psr7
via your HttpClient, because they are checking the argument withis_string()
inside their Uri implementation. https://github.com/guzzle/psr7/blob/master/src/Uri.php#L383The text was updated successfully, but these errors were encountered: