#-comments

[GoogleCodeExporter]

Hi,

could you pls replace '#' comments with the '//'

Thanks

Original issue reported on code.google.com by m...@mail.ru on 18 Sep 2013 at 7:26

[GoogleCodeExporter]

Why?

Original comment by mewp...@gmail.com on 18 Sep 2013 at 8:12

[GoogleCodeExporter]

well, there is nothing wrong with linux shell comments in php,as official 
documentation states...

It is just a feature request... I am trying to conform this 
http://kohanaframework.org/3.3/guide/kohana/conventions#comments maybe it also 
makes sense for you... 

also these sharp comments got my syntax highlighter  just crazy :)

Original comment by m...@mail.ru on 18 Sep 2013 at 10:01

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

if you have not a time for that then I could prepare a patch

Original comment by m...@mail.ru on 18 Sep 2013 at 10:15

[GoogleCodeExporter]

sh (and other shells), python, perl, ruby, php, tcl, and other languages use 
#-comments. If your syntax highlighter can't handle that, it's a bug with the 
highlighter, not with LightOpenID code.

php, c/c++, and java use //-comments. I personally think that #-commments are 
more fitting for a dynamic language, but regardless -- I don't see a reason to 
include a patch changing a completely arbitrary thing in the code, that doesn't 
affect functionality, readability, robustness, or really anything else.

Furthermore, I don't consider kohana framework style conventions a superior 
(or, for that matter, inferior) to other conventions, including the one that 
LightOpenID uses.

In one sentence: It would be a useless change.

Original comment by mewp...@gmail.com on 19 Sep 2013 at 11:01

• Changed state: WontFix