Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-xrds-location header ignored (No server found for AOL) #8

Closed
GoogleCodeExporter opened this issue Mar 21, 2015 · 1 comment
Closed

Comments

@GoogleCodeExporter
Copy link

Hi,

the x-xrds-location header is ignored because of an upper case letter in the 
key name. $this->request($url, 'HEAD') converts all header names to lower case.

The following patch will redirect to the AOL login screen instead of failing 
with "No server found". I don't have an AOL account, so i cannot test the 
validation part.

--- lightopenid.php     26 Sep 2010 21:14:23 -0000      1.4
+++ lightopenid.php     27 Sep 2010 00:16:20 -0000
@@ -227,8 +227,8 @@
                 $headers = $this->request($url, 'HEAD');

                 $next = false;
-                    if (isset($headers['x-xrds-Location'])) {
-                        $url = $this->build_url(parse_url($url), 
parse_url(trim($headers['x-xrds-Location'])));
+                if (isset($headers['x-xrds-location'])) {
+                        $url = $this->build_url(parse_url($url), 
parse_url(trim($headers['x-xrds-location'])));
                         $next = true;
                     }

Original issue reported on code.google.com by HendrikU...@nexgo.de on 27 Sep 2010 at 12:17

@GoogleCodeExporter
Copy link
Author

Of course, you're right. I didn't notice it while changing the case of headers.

Thanks for the report and continued testing.

Original comment by mewp...@gmail.com on 27 Sep 2010 at 11:02

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant