Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuthStoreMySQL.php - should fail when connect fails. #6

Closed
GoogleCodeExporter opened this issue Mar 21, 2015 · 1 comment
Closed

OAuthStoreMySQL.php - should fail when connect fails. #6

GoogleCodeExporter opened this issue Mar 21, 2015 · 1 comment
Labels
auto-migrated Priority-Medium Type-Enhancement

Comments

@GoogleCodeExporter
Copy link 

When the mysql_connect fails the OAuthStoreMySQL initializer should abandon 
with an error 
message.

Now it silently fails, giving SQL errors when the database is accessed.

Original issue reported on code.google.com by ma...@pobox.com on 18 Feb 2009 at 1:40
@GoogleCodeExporter
Copy link
Author 

This has been fixed by Scherpeniss in r59.

Better error handling in MySQL OAuth store:
 * Throw an OAuthException when db connection fails
 * Throw an OAuthException instead of die() when encountering a SQL error

- Marc

Original comment by ma...@pobox.com on 16 Aug 2009 at 7:41

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter